Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continuous ALE #549

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Continuous ALE #549

merged 4 commits into from
Aug 13, 2024

Conversation

jjshoots
Copy link
Member

@jjshoots jjshoots commented Jul 31, 2024 •
edited by pseudo-rnd-thoughts
Loading

Todo:

  • Make Cpp API pure continuous
  • Python-side continuous, quantized, discrete

@jjshoots jjshoots marked this pull request as draft August 1, 2024 05:44
@pseudo-rnd-thoughts
Copy link
Member

could you update the project version, I think there are a couple of places this needs to be done including the ci.yml

@pseudo-rnd-thoughts
Copy link
Member

For testing, it might be worth reducing the number of tests for continuous down to only {env-id}-v0 or v5, as we are basically doubling the testing time required currently

@jjshoots jjshoots marked this pull request as ready for review August 13, 2024 10:53
@jjshoots
Copy link
Member Author

@pseudo-rnd-thoughts Good idea, I'll revisit that in the coming days.

@pseudo-rnd-thoughts
Copy link
Member

We can do it in another PR

@pseudo-rnd-thoughts pseudo-rnd-thoughts merged commit df15078 into master Aug 13, 2024
56 checks passed
@pseudo-rnd-thoughts pseudo-rnd-thoughts deleted the CALE branch August 30, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pseudo-rnd-thoughts pseudo-rnd-thoughts pseudo-rnd-thoughts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjshoots @pseudo-rnd-thoughts @psc-g